Adopt the upcoming feature SE-0409 (access-level modifiers on import declarations) #1183
Conversation
|
@swift-ci please test |
|
@swift-ci please test |
So far people have for the most part been good about not introducing code warnings. Every now and then someone—myself included—misses a warning. This can for example happen when updating a PR with the latest changes from main. However, these added warnings are generally fixed fairly quickly. That said, the CI includes some concurrency warnings that most people don't see in their local builds. It's possible that we'd be able to treat warnings as errors in the future, but right now it would be too disruptive since we haven't addressed those warnings yet. Some of those are false positives where there's another synchronization mechanism in play and some require updating dependencies to versions that we're currently unable to adopt. |
Bug/issue #, if applicable:
Summary
This opts in to the upcoming feature SE-0409 (access-level modifiers on import declarations).
By making imports internal by default we make it explicit when imported dependencies are visible to library clients.
By incrementally adopting certain features beforehand we can make the future changes for updates to future languages versions smaller.
Dependencies
None
Testing
Nothing in particular. This isn't a user-facing change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[] Added tests./bin/testscript and it succeeded[ ] Updated documentation if necessary